Repository navigation
fix(web-ui): prevent tab text selection and add device-group close-all menu - #3932
Merged
bobleer merged 1 commit intoNov 16, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-webkit-user-select: noneanduser-select: noneto.tabGroupand.tabin@openbitfun/ui(TabGroup.module.css), as well asSceneBar.scss,SceneTopBar.scss, and content-canvasTab.scss.onContextMenuCaptureinTabGroupandSceneBar(handling macOS WKWebView secondary-click automatic word selection without blockingselectstart, preserving nativedraggable="true"tab drag-and-drop and any user text selection outside the tab bar).cursor: defaulton.openbitfun-scene-bar__device-groupwhile keeping<span role="presentation">outsideSceneTopBar's interactive selector so native window dragging and double-click maximize remain unaffected.sceneBar.closeDeviceTabsinen-US,zh-CN, andzh-TW) when right-clicking a device group label inSceneBarto close all closable tabs belonging to that devicesurfaceId(closing inactive tabs before the active tab to avoid intermediate fallback session hydrations, stopping on unsaved/draft close guards, and fencing/dismissing on Peer surface switches).Type and Areas
Type: Bug fix / UI/UX
Areas: Design System (
design-system/packages/ui), Web UI (src/web-ui)Motivation / Impact
SceneBar, users can right-click a device name to close all closable tabs under that device in one action.Verification
pnpm --dir design-system run build:ui && node --test design-system/packages/ui/tests/tab-group.test.mjs(13/13 passed)pnpm --dir src/web-ui run test:run src/app/components/SceneBar/SceneBar.test.tsx src/app/components/SceneBar/useSceneTabNavigation.test.tsx src/app/components/SceneBar/SceneBar.performance.test.tsx src/app/components/SceneTopBar/SceneTopBar.test.tsx src/app/stores/sceneStore.test.ts src/app/services/sessionSceneLifecycle.test.ts src/app/components/panels/content-canvas/tab-bar/TabBar.test.tsx(7 test files, 117/117 passed)pnpm run i18n:audit(passed, 0 warnings)pnpm run check:web(typography, appearance contract, theme color, theme visual governance, andtsc --noEmitall passed)pnpm run check:repo-hygiene && git diff --check(passed)node scripts/check-git-object-sizes.mjs --base upstream/main --head HEAD(passed)surfaceIdgrouping (local+ peer device) andactivateSurfacePeer surface-switch fencing/dismissal; not exercised on live SSH Remote Workspace, Remote Control relay, live Peer Device hosts, Detached Dispatch, or native macOS WKWebView runtime.Reviewer Notes
Checklist